Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (scf) small refactor for index_switch #3178

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

alexarice
Copy link
Collaborator

As discussed in #3157 (comment)

@alexarice alexarice added dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous labels Sep 17, 2024
@alexarice alexarice self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (7e2b0f7) to head (706dfa8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3178      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.01%     
==========================================
  Files         430      431       +1     
  Lines       54183    54205      +22     
  Branches     8392     8395       +3     
==========================================
+ Hits        48784    48800      +16     
- Misses       4043     4048       +5     
- Partials     1356     1357       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@alexarice alexarice merged commit 7d0a295 into main Sep 17, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/switch-refactor branch September 17, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants