transformations: Add convert-arith-to-varith pass #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLydike
added
hackathon
AntonLydike
force-pushed
the
anton/arith-to-varith
branch
3 times, most recently
from
3ea0950
to
65f9823
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3242 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 441 442 +1
Lines 55417 55479 +62
Branches 8643 8655 +12
=======================================
+ Hits 49832 49889 +57
- Misses 4158 4161 +3
- Partials 1427 1429 +2 ☔ View full report in Codecov by Sentry. |
AntonLydike
force-pushed
the
anton/arith-to-varith
branch
from
65f9823
to
f6ec47f
Compare
AntonLydike
force-pushed
the
anton/arith-to-varith
branch
from
f6ec47f
to
a377199
Compare
dk949
approved these changes
Oct 4, 2024
|
|
||
| class MergeVarithOpsPattern(RewritePattern): | ||
| """ | ||
| Merges operands that are varith or arith ops into |
There was a problem hiding this comment.
I'm not quite sure what you mean here
There was a problem hiding this comment.
Expanded on it!
| if len(possibly_erased_ops) == 0: | ||
| return | ||
|
|
||
| rewriter.replace_matched_op(type(op)(*new_operands)) # pyright: ignore[reportUnknownArgumentType] |
There was a problem hiding this comment.
nit: Could you include a comment for why you need to ignore the warning?
AntonLydike
force-pushed
the
anton/arith-to-varith
branch
from
5f622a5
to
f5d7ec2
Compare
45 tasks
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
Adds a pass `convert-arith-to-varith` that converts arith adds and muls to varith adds and muls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pass
convert-arith-to-variththat converts arith adds and muls to varith adds and muls. More tests coming.Stacked on top of #3241