Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module with Http4s Blaze server #51

Draft
wants to merge 2 commits into
base: async-instance
Choose a base branch
from

Conversation

gregorath
Copy link
Collaborator

@gregorath gregorath commented Oct 26, 2022

on top of #42 as we need the Async instance.

an initial attempt to add the http4s backend server, currently blocked while waiting to see if we can make Async.uncancelable work and use it.

Copy link
Collaborator

@jackcviers jackcviers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with the suggested changes, we can see that we're at least failing in the same way the other Async PRs are failing WRT cats-effect/loom integration. At least this test removes discipline law tests from the problem definition -- somehow, the fiber is not in the correct ownership context when fork is called.

I don't know why that may be the case yet. It will take some more debugging.

@gregorath
Copy link
Collaborator Author

gregorath commented Nov 3, 2022

The comments have been addressed in 62cfea3 but as said this won't work until we have the Async instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants