Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base URL for Ktor client #10

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Use base URL for Ktor client #10

merged 1 commit into from
Apr 27, 2023

Conversation

franciscodr
Copy link
Contributor

This pull request adds the OpenAI API base URL to the config class. Additionally, it proposes using the defaultRequest builder for the Ktor client to specify the base URL, so we only need to set the specific path for the endpoint to which we want to send the request.

@franciscodr
Copy link
Contributor Author

@nomisRev @realdavidvega @gutiory This pull request is ready for review. Thanks!

Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @franciscodr

@franciscodr franciscodr merged commit 216682a into main Apr 27, 2023
@franciscodr franciscodr deleted the using-base-url branch April 27, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants