Scala Json Parsing #100
Merged
Scala Json Parsing #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @xebia-functional/team-ai |
raulraja
approved these changes
May 24, 2023
Yawolf
reviewed
May 24, 2023
Yawolf
reviewed
May 24, 2023
Co-authored-by: Yago Cervantes <1420230+Yawolf@users.noreply.github.com>
Yawolf
reviewed
May 24, 2023
| SerialDescriptor[A].serialDescriptor, | ||
| decode[A](_).fold(throw _, identity), | ||
| ScalaSerialDescriptor[A].serialDescriptor, | ||
| (json) => parse(json).flatMap(Decoder[A].decodeJson(_)).fold(throw _, identity), |
There was a problem hiding this comment.
I'm okay with this, but it failed in the previous build because io.circe.parse.decoder is needed 🙂
There was a problem hiding this comment.
Maybe I misunderstood your suggestion, but that was failing compilation. Feel free to update this to whatever you feel is most idiomatic
Decoder.decodeJson takes a Json and not a String, so I used parse first.
Yawolf
approved these changes
May 24, 2023
juanpedromoreno
approved these changes
May 24, 2023
|
@Yawolf I am going to merge this PR, but feel free to update or propose a better more Scala idiomatic encoding in a different PR, or in a subsequent PR where we try to implement some examples. My Scala experience is extremely limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state: Cannot resolve correct signature