JDBC Postgres VectorStore #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@franciscodr @realdavidvega @gutiory this PR is ready for review, and adds the same implementation as langchain4s does with Doobie but with plain JDBC. |
juanpedromoreno
approved these changes
Apr 27, 2023
src/commonTest/kotlin/com/xebia/functional/config/ConfigSpec.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Apr 27, 2023
src/commonMain/kotlin/com/xebia/functional/embeddings/OpenAIEmbeddings.kt
Outdated
Show resolved
Hide resolved
franciscodr
reviewed
Apr 27, 2023
src/commonMain/kotlin/com/xebia/functional/vectorstores/VectorStore.kt
Outdated
Show resolved
Hide resolved
franciscodr
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Just a final message :p Looks good to me, @nomisRev Thanks!
Co-authored-by: Francisco Diaz <francisco.d@47deg.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a JDBC implementation for Postgres VectorStore.
The common stuff like the queries live inside Kotlin KMP, so we can re-use them to add implementations for different platforms such as Native using https://github.com/hfhbd/postgres-native-sqldelight.
We could easily do the same for NodeJS by relying on a NodeJS Postgres driver.