Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up common repositories for subprojects #22

Merged
merged 1 commit into from
May 3, 2023
Merged

Set up common repositories for subprojects #22

merged 1 commit into from
May 3, 2023

Conversation

franciscodr
Copy link
Contributor

This pull request centralizes the declaration of the common repositories in the settings.gradle.kts file using the dependencyResolutionManagement block. Check it out in the Gradle documentation

@franciscodr
Copy link
Contributor Author

@juanpedromoreno @nomisRev @realdavidvega Ready for review. Thanks!

juanpedromoreno
juanpedromoreno approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @franciscodr , LGTM

nomisRev
nomisRev approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @franciscodr 🖐️

@nomisRev nomisRev merged commit d36f9d1 into main May 3, 2023
@nomisRev nomisRev deleted the setting-up-common-repositories branch May 3, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscodr @juanpedromoreno @nomisRev