Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds scalafmt via spotless plugin #24

Merged
merged 1 commit into from
May 3, 2023
Merged

Adds scalafmt via spotless plugin #24

merged 1 commit into from
May 3, 2023

Conversation

juanpedromoreno
Copy link
Contributor

@juanpedromoreno juanpedromoreno commented May 3, 2023 •
edited
Loading

This PR adds the scalafmt configuration for the scala module through the Gradle spotless plugin.

@juanpedromoreno
Copy link
Contributor Author

@nomisRev @franciscodr Could you please take a look at this one? Thanks!

@juanpedromoreno juanpedromoreno requested a review from Yawolf May 3, 2023 12:23
nomisRev
nomisRev approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me 🙌 I only reviewed README.MD & build.gradle.kts.

franciscodr
franciscodr approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, LGTM!

@juanpedromoreno juanpedromoreno merged commit 565395f into main May 3, 2023
@juanpedromoreno juanpedromoreno deleted the scalafmt branch May 3, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@franciscodr franciscodr franciscodr approved these changes

@Yawolf Yawolf Awaiting requested review from Yawolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juanpedromoreno @franciscodr @nomisRev