Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Add memories with functions #280

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fixing Add memories with functions #280

merged 1 commit into from
Jul 27, 2023

Conversation

javipacheco
Copy link
Contributor

When we add memories on ChatCompletionRequestWithFunctions the content is empty and should use functionCall?.arguments. This arguments contains the JSON string response from OpenAI.

This is important because using conversations if we have ASSISTANTS messages with empty content, OpenAI mix the last USER messages given random responses.

@anamariamv anamariamv requested review from a team, raulraja and franciscodr and removed request for a team July 27, 2023 16:12
@raulraja raulraja merged commit e6f900a into main Jul 27, 2023
@raulraja raulraja deleted the add-memories-with-functions branch July 27, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

@franciscodr franciscodr Awaiting requested review from franciscodr franciscodr was automatically assigned from xebia-functional/team-xef-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javipacheco @raulraja