Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SequenceChain Implementation #29

Merged
merged 7 commits into from
May 9, 2023
Merged

SequenceChain Implementation #29

merged 7 commits into from
May 9, 2023

Conversation

Yawolf
Copy link
Contributor

@Yawolf Yawolf commented May 4, 2023

Adding SequenceChain feature.

franciscodr
franciscodr approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first Kotlin task, @Yawolf! 🚀

nomisRev
nomisRev approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive for your first Kotlin PR @Yawolf 👏 👏 👏
2 questions, and 1 nit but nothing blocking 🙌

kotlin/src/commonMain/kotlin/com/xebia/functional/chains/SequenceChain.kt Show resolved Hide resolved
kotlin/src/commonMain/kotlin/com/xebia/functional/chains/SequenceChain.kt Outdated Show resolved Hide resolved
kotlin/src/commonMain/kotlin/com/xebia/functional/chains/SequenceChain.kt Outdated Show resolved Hide resolved
kotlin/src/commonMain/kotlin/com/xebia/functional/chains/SimpleSequenceChain.kt Show resolved Hide resolved
Yawolf and others added 4 commits May 8, 2023 11:54
@Yawolf @nomisRev
Update kotlin/src/commonMain/kotlin/com/xebia/functional/chains/Seque…
0e8216b 
…nceChain.kt

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
@Yawolf @nomisRev
Update kotlin/src/commonMain/kotlin/com/xebia/functional/chains/Seque…
430498b 
…nceChain.kt

Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com>
@Yawolf
Merge branch 'master' into sequential-chain-sqc
b7976f3
@Yawolf
Some requested changes
898c2da
nomisRev
nomisRev approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very impressive work @Yawolf 🙌

@Yawolf
Copy link
Contributor Author

Yawolf commented May 9, 2023

Very impressive work @Yawolf 🙌

Thank you @nomisRev, and thank you too @franciscodr

@Yawolf Yawolf merged commit 7b29ab5 into main May 9, 2023
@Yawolf Yawolf deleted the sequential-chain-sqc branch May 9, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@franciscodr franciscodr franciscodr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yawolf @franciscodr @nomisRev