Simplify conversations and their JVM integrations #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
commented
Aug 13, 2023
raulraja
commented
Aug 13, 2023
core/src/commonMain/kotlin/com/xebia/functional/xef/auto/Conversation.kt
Show resolved
Hide resolved
raulraja
commented
Aug 13, 2023
core/src/commonMain/kotlin/com/xebia/functional/xef/auto/Conversation.kt
Show resolved
Hide resolved
raulraja
commented
Aug 13, 2023
core/src/commonMain/kotlin/com/xebia/functional/xef/auto/Conversation.kt
Show resolved
Hide resolved
raulraja
commented
Aug 13, 2023
core/src/commonMain/kotlin/com/xebia/functional/xef/auto/Conversation.kt
Show resolved
Hide resolved
raulraja
commented
Aug 13, 2023
java/src/main/java/com/xebia/functional/xef/java/auto/AIScope.java
Outdated
Show resolved
Hide resolved
raulraja
commented
Aug 13, 2023
reasoning/src/jvmMain/kotlin/com/xebia/functional/xef/reasoning/pdf/ReadPDFFromUrl.kt
Show resolved
Hide resolved
raulraja
commented
Aug 13, 2023
raulraja
commented
Aug 13, 2023
* Diff summary tool and create PR Description example * Fixed copy pasta
javipacheco
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way language support is built for Java and Scala by making the
Conversationmethods available in a JVM-specific implementation that uses aCoroutineScopewith a supervisor to turn the suspend functions into versions that returnCompletableFuture,and that can be consumed from other langs.For now, the
Scalalib andJavaexamples consume those methods in a blocking style assuming LOOM is available.I'll leave comments on the files in the most relevant parts.