Server support stream #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
reviewed
Aug 23, 2023
server/src/main/kotlin/com/xebia/functional/xef/server/http/routes/Routes.kt
Outdated
Show resolved
Hide resolved
raulraja
reviewed
Aug 23, 2023
server/src/main/kotlin/com/xebia/functional/xef/server/http/routes/Routes.kt
Show resolved
Hide resolved
raulraja
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
We could test this change live by creating our xef-client, which uses the OpenAI Models we have in Xef but instead uses our server URL. Sending a streaming request like the SpaceCraft example that streams the response will show if this integration is wired the same as Open AIs. Let's discuss it tomorrow to see how we can approach it and if we can already write some tests for it.
javipacheco
requested changes
Aug 24, 2023
server/src/main/kotlin/com/xebia/functional/xef/server/http/routes/Routes.kt
Show resolved
Hide resolved
server/src/main/kotlin/com/xebia/functional/xef/server/http/routes/Routes.kt
Show resolved
Hide resolved
server/src/main/kotlin/com/xebia/functional/xef/server/http/routes/Routes.kt
Show resolved
Hide resolved
|
@raulraja the last changes added to this PR add the possibility to change the host in order to use the |
raulraja
approved these changes
Aug 28, 2023
javipacheco
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
chat/completionsendpoint to support the stream option. Now this endpoint uses a Ktor client to send the information directly to OpenAI and returns the output in the same format as received.