-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAIEmbeddings to core module #380
Conversation
Considering the scope of the issue, LGTM. For another issue, I suggest making the These are just my humble thoughts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @javipacheco , thanks!
In this or another PR, we must address the number and size of messages for embedding requests. We have been defaulting to 400
or configured chunk size, but we know the max content length of the model, which would allow us to send fewer and lengthier requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR removes
OpenAIEmbeddings
and I'm adding the implementation of this tocom.xebia.functional.xef.llm.Embeddings
and nowcom.xebia.functional.xef.embeddings.Embeddings
is not necessary