CU-865ca0fvw Pass LLMModel through all chains #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into cu-865ca0fvw-configurable-model # Conflicts: # kotlin/src/commonTest/kotlin/com/xebia/functional/chains/CombineDocsChainSpec.kt # kotlin/src/commonTest/kotlin/com/xebia/functional/chains/LLMChainSpec.kt # kotlin/src/commonTest/kotlin/com/xebia/functional/chains/VectorQAChainSpec.kt
…able-model # Conflicts: # kotlin/src/commonMain/kotlin/com/xebia/functional/chains/LLMChain.kt # kotlin/src/commonTest/kotlin/com/xebia/functional/chains/CombineDocsChainSpec.kt # kotlin/src/commonTest/kotlin/com/xebia/functional/chains/LLMChainSpec.kt # kotlin/src/commonTest/kotlin/com/xebia/functional/chains/VectorQAChainSpec.kt
|
@xebia-functional/team-ai I think this is ready for review |
|
Looks great to me, thanks @raulraja! 🙂 |
realdavidvega
approved these changes
May 10, 2023
nomisRev
reviewed
May 10, 2023
| ): Chain = object : Chain { | ||
|
|
||
| private val inputKeys: Set<String> = promptTemplate.inputKeys.toSet() |
There was a problem hiding this comment.
nit: Quite some unrelated formatting changes. We need to fix spotless, I can raise a PR after this one gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new
LLMModelpassed through all chains that may depend on the LLMChain to run its internal operations. Ultimately we need a way to pass all config related to temperature etc., to the functions that perform a prompt. Both in Chains but also in the AI dsl at #33