Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[428] Better error handling in Xef Server #430

Merged
merged 4 commits into from
Sep 18, 2023
Merged

[428] Better error handling in Xef Server #430

merged 4 commits into from
Sep 18, 2023

Conversation

Montagon
Copy link
Contributor

No description provided.

@Montagon Montagon linked an issue Sep 15, 2023 that may be closed by this pull request
Response validation in Xef Server #428
Closed
@Montagon Montagon marked this pull request as draft September 15, 2023 11:09
@Montagon
Copy link
Contributor Author

This PR will be updated in order to work with Arrow.

@Montagon Montagon marked this pull request as ready for review September 18, 2023 13:58
javipacheco
javipacheco approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@javipacheco javipacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

I have tried the code locally and everything works as expected. We will address to include Arrow lib in a separate PR

@Montagon Montagon merged commit 8155a54 into main Sep 18, 2023
5 checks passed
@Montagon Montagon deleted the 428-response-validation-in-xef-server branch September 18, 2023 15:03
@Intex32
Copy link
Member

Intex32 commented Sep 19, 2023

I have tried the code locally and everything works as expected. We will address to include Arrow lib in a separate PR

Are you going to use Arrow's Either and EitherNel for error handling? What are your plans?

@Montagon
Copy link
Contributor Author

I have tried the code locally and everything works as expected. We will address to include Arrow lib in a separate PR

Are you going to use Arrow's Either and EitherNel for error handling? What are your plans?

The plan is to apply the same approach as here: https://github.com/nomisRev/ktor-arrow-example/pull/35/files#diff-fd19be7abb78848f1cf6bc8da926adafd98399c75cf49662e9a8dcc29f7f3cb0R33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intex32 Intex32 Intex32 left review comments

@javipacheco javipacheco javipacheco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response validation in Xef Server
3 participants
@Montagon @Intex32 @javipacheco