Fix - GenericIOException: Failed to parse HTTP response: unexpected EOF #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomascayuelas
changed the title
raulraja
previously approved these changes
Oct 11, 2023
openai/src/commonMain/kotlin/com/xebia/functional/xef/conversation/llm/openai/OpenAI.kt
Outdated
Show resolved
Hide resolved
raulraja
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Testing our library in a simple use case we have detected that with a newly generated personal OPENAI_TOKEN. When we use it we get this exception
(com.aallam.openai.api.exception.GenericIOException: Failed to parse HTTP response: unexpected EOF)Why?
Because the Timeout establishes a default time of 30 seconds for the socket, so if this request spend more time that this value (socket = 30.seconds) the execution thrown an exception.
How?
We have added a configurable Timeout with some default values in our OpenAI class. This solves the timeout problem given by the "com.aallam" OpenAI library client, issue already closed aallam/openai-kotlin#234
Other minor changes:
We take the opportunity to do this little refactor: