Update parameters type in CFunction to JsonObject #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montagon
commented
Oct 20, 2023
core/src/jvmMain/kotlin/com/xebia/functional/xef/conversation/PlatformConversation.jvm.kt
Show resolved
Hide resolved
raulraja
previously approved these changes
Oct 20, 2023
core/src/jvmMain/kotlin/com/xebia/functional/xef/conversation/PlatformConversation.jvm.kt
Show resolved
Hide resolved
fedefernandez
previously approved these changes
Oct 24, 2023
core/src/commonMain/kotlin/com/xebia/functional/xef/llm/models/functions/JsonSchema.kt
Show resolved
Hide resolved
core/src/jvmMain/kotlin/com/xebia/functional/xef/conversation/PlatformConversation.jvm.kt
Show resolved
Hide resolved
…ef into update-cfunction-type
fedefernandez
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition of
CFunctioncontemplates theparametersas a string. But, when trying to generate data for fine-tuning, the types are not correct. Now the parameters property is a JsonObject as it is in OpenAI.