Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Gradle to 8.4 & Scala JVM to 21; clean up build scripts #516

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Upgrade Gradle to 8.4 & Scala JVM to 21; clean up build scripts #516

merged 2 commits into from
Nov 2, 2023

Conversation

L-Lavigne
Copy link
Collaborator

Summary of changes:

  • Updated Gradle to 8.4, enabling Scala compilation with Java 21 without enable-preview (Gradle itself is still limited to Java 20);
  • Cleaned up build scripts by normalizing indentation and reducing empty lines;
  • Fixed a few inconsistencies in the Java and Scalafmt versions used in scripts, and Kotlin version in docs;
  • Fixed some incorrect code-block language tags in docs;
  • Added some IDEA runconfigs for convenience (in .run, not .idea/).

@L-Lavigne L-Lavigne added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file build labels Nov 1, 2023
Montagon
Montagon approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@L-Lavigne L-Lavigne merged commit 0e42da2 into main Nov 2, 2023
5 checks passed
@L-Lavigne L-Lavigne deleted the upgrade-gradle-and-jvm branch November 2, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montagon Montagon Montagon approved these changes

@raulraja raulraja Awaiting requested review from raulraja

@jackcviers jackcviers Awaiting requested review from jackcviers

@juanpedromoreno juanpedromoreno Awaiting requested review from juanpedromoreno

Assignees
No one assigned
Labels
build dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-Lavigne @Montagon