Fix request timeout on OpenAI calls #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Montagon
approved these changes
May 16, 2023
franciscodr
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
HttpTimeoutktor plugin and setting default timeout of all OpenAI requests to 30 seconds.max_tokensdue to now having larger prompts. BUT I think this is something we should calculate by ourselves by using a Tokenizer to get the number of tokens of our prompt, and subtracting it from the maximum context length of the selected model. That way we can also raise an error before sending the request to OpenAI. In that sense, I have just added for now thecontextLengthof eachLLMModel.cc: @xebia-functional/team-ai