Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tokenizer dependencies in main #77

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

raulraja
Copy link
Contributor

No description provided.

@raulraja
Copy link
Contributor Author

We now have a situation where there seems to be some duplication in LLModel and ModelType, which are the models the tokenizer use. I don't know if we should mix or keep them entirely separate, but it would be nice to have a common way to refer to models by name. There is also the open question of how the tokenizer library will work for hugging face and local models.

@nomisRev
Copy link
Contributor

@realdavidvega is working on a small improvement to close the gap, we need it in tokenizer if we intend to publish it as a separate library soon but I guess we can rely on that from the main library also. We'd only need a tuple to add the Kind.Chat to it.

@nomisRev nomisRev merged commit 6f39b9e into main May 19, 2023
@nomisRev nomisRev deleted the fix-tokenizer-deps branch May 19, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants