Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chain + LLMChain #9

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Chain + LLMChain #9

merged 6 commits into from
Apr 25, 2023

Conversation

realdavidvega
Copy link
Contributor

@realdavidvega realdavidvega commented Apr 25, 2023 •
edited
Loading

This PR adds BaseChain and LLMChain components and their respective tests.
LLMChain integrates with the OpenAIClient (later we have to port it to one generic LLM) and the PrompTemplate .

@realdavidvega realdavidvega changed the title [WIP] Base chains [WIP] BaseChain + LLMChain Apr 25, 2023
@realdavidvega realdavidvega changed the title [WIP] BaseChain + LLMChain BaseChain + LLMChain Apr 25, 2023
@realdavidvega
Copy link
Contributor Author

@franciscodr @nomisRev @gutiory @raulraja ready for review.

nomisRev
nomisRev approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me @realdavidvega! Only some nits, nothing blocking ☺️

src/commonMain/kotlin/com/xebia/functional/chains/LLMChain.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/com/xebia/functional/chains/models.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/com/xebia/functional/chains/BaseChain.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/com/xebia/functional/chains/models.kt Outdated Show resolved Hide resolved
src/commonMain/kotlin/com/xebia/functional/chains/BaseChain.kt Outdated Show resolved Hide resolved
realdavidvega and others added 2 commits April 25, 2023 16:00
@realdavidvega realdavidvega changed the title BaseChain + LLMChain Chain + LLMChain Apr 25, 2023
@realdavidvega realdavidvega merged commit e8a4eca into main Apr 25, 2023
@realdavidvega realdavidvega deleted the base-chains branch April 25, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@franciscodr franciscodr Awaiting requested review from franciscodr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realdavidvega @nomisRev