Support ScalaSerialDescriptor composite case classes #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
approved these changes
May 24, 2023
| case _: (h *: t) => summonInline[ClassTag[h]] :: getElemTypes[t] | ||
| case _: (h *: t) => | ||
| summonInline[ClassTag[h]].runtimeClass.toString match { | ||
| case s if s.toLowerCase.contains("boolean") => KotlinXSerializers.boolean.getDescriptor :: getElemTypes[t] |
There was a problem hiding this comment.
For all these cases, what happens if a type is called something like MyCustomBoolean? I think it's going to use the KotlinXSerializers.boolean.getDescriptor, which is not the right serializer. We should be matching against precise class names and not String contents.
case klass if s == summonInline[ClassTag[Boolean]].runtimeClass =>There was a problem hiding this comment.
That's a very good point. Will get it fixed
franciscodr
approved these changes
May 24, 2023
There was a problem hiding this comment.
Beyond Raul's comment, this pull request is a great improvement. Thanks, @necosta!
Yawolf
reviewed
May 24, 2023
scala/src/main/scala/com/xebia/functional/auto/ScalaSerialDescriptor.scala
Outdated
Show resolved
Hide resolved
scala/src/main/scala/com/xebia/functional/auto/ScalaSerialDescriptorContext.scala
Show resolved
Hide resolved
Yawolf
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now serialise case classes containing case classes members. 🎉 (see unit-tests)
Notes:
derivedmethods had theoverridekeyword and some not, I set all withoverride.Ready for review.