-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundle size optimization for Blueprint Icons #44
Comments
@cnrudd if you have a chance to review - we could look together tomorrow as I'd like to cut a dev-utils release with an even bigger fix to FontAwesome icons. |
Looking now. |
This has been fixed in this hoist-dev-utils branch: and can be tested easily in toolbox branch BP4 brought in a requirement for using a new method for getting the icon name, which I have added into the requireBlueprintIcons.js file and moved the file (as per discussions) into the hoist-dev-utils project to avoid creating a breaking change dependency between hoist-dev-utils and hoist-react. (See palantir/blueprint#2193 (comment) for more details on the new method) I have committed some temporary changes to the package.json files in the Bundle analysis on the build using the bpIcons branch of hoist-dev-utils shows a much smaller BlueprintJS Icons package. |
Reviewing a recent bundle treemap on our Toolbox app, it looks like the big Blueprint icons package has returned and is taking up a lot of space again. My bet is that something about the path changed, and the workaround we implemented in #25 a while back needs to be updated.
The text was updated successfully, but these errors were encountered: