-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window / Dialog component - replaces direct use of Blueprint dialog #861
Comments
I was actually thinking it might be interesting to offer something like XH.dialog() or XH.window() that would popup a window or dialog imperatively, much like messages get popped-up with XH.message(). That way, applications would not need to have to deal with the whole "isOpen" bookkeeping and needing to place the thing manually into the virtual DOM. Question is how to to specify buttons and how to allow the content in the dialog the ability to close the window.... |
For the first step BP dialog wrapper component with defaulted props:
|
Lee and I reviewed the code in branch 'hoistDialog', which produces a draggable/resizeable dialog or fixed pos/size dialog. We determined we want to make Dialog a function component with its own model (much like Panel). Model should have these API properties and methods:Properties
(All properties should be observable) Methods
Component should take these props:
Also explore if same dialog component can be used on mobile. Maybe not allow resizable or draggable on mobile. |
Still to do:
|
Leaving this here in case relevant at all - https://tympanus.net/codrops/2021/10/06/how-to-implement-and-style-the-dialog-element/ |
We make frequent and direct use of the Blueprint Dialog out of
kit
. There are some concrete issues with this:We could consider:
The text was updated successfully, but these errors were encountered: