Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply background color earlier by retrieving AWS session data from meta #89

Open
2 of 8 tasks
KojiAndoJC opened this issue Sep 21, 2024 · 2 comments
Open
2 of 8 tasks

Comments

@KojiAndoJC
Copy link

Description

There is a meta tag named awsc-session-data which contains accountId and infrastructureRegion. I would appreciate if the extension could use this data to apply background colors earlier.

Motivation

Even after setting colors with this extension, the default color of the AWS Management Console is displayed for a few seconds. This is confusing for users.

Additionally, I attempted to implement this feature, but encountered some difficulties:

  • The accountMenuButtonBackgroundColor was not applied correctly.
  • I lack knowledge about elements like span[data-testid="account-menu-button__background"] and couldn't design the proper logic.

You can see my implementation attempt here:
KojiAndoJC@be12332

Sign in Method

  • Direct login to target account via AWS SSO
  • Direct login to target account via IAM user
  • Login to a jump account via AWS SSO, then switch role to target account
  • Login to a jump account via IAM user, then switch role to target account
  • Sign in as the root user

Acknowledge

  • This feature request is based on actual problems that have occurred after using the extension in YOUR practice.
  • I may be able to implement this feature request
  • This feature might incur a breaking change
@xhiroga
Copy link
Owner

xhiroga commented Sep 22, 2024

Thank you for your excellent suggestion about using the awsc-session-data meta tag, @KojiAndoJC san!

I've verified its presence in the AWS console, and it seems to contain the right information even for Assume Role and root user scenarios. This approach looks nice for improving color application speed and make code easy to understand.

I'm considering incorporating this method in an upcoming release, but contributions are also very welcome if you'd like to implement it yourself. Your feedback is truly appreciated😀

@KojiAndoJC
Copy link
Author

Thank you for considering my suggestion, @xhiroga! I'm looking forward to your implementation and happy to provide any additional input if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants