Summary
An unsafe sanitization of dataset contents on the MarkovData#getNext method used in Markov#generate and Markov#choose allows a maliciously crafted string on the dataset to throw and stop the function from running properly.
Details
|
getNext(current: string) { |
|
if (!current) return; |
|
const data = this.finalData[current.slice(0, -1)]; |
|
if (!data) return; |
|
const random = Math.floor(Math.random() * data.length); |
|
return data[random].endsWith(' ') ? data[random] : `${data[random]} `; |
|
} |
If a string contains a forbidden substring (i.e. __proto__) followed by a space character, the second line will access a special property in MarkovData#finalData by removing the last character of the string, bypassing the dataset sanitization (as it is supposed to be already sanitized before this function is called).
data is then defined as the special function found in its prototype instead of an array.
On the last line, data is then indexed by a random number, which is supposed to return a string but returns undefined as it's a function. Calling endsWith then throws.
PoC
https://runkit.com/embed/m6uu40r5ja9b
Impact
Any dataset can be contaminated with the substring making it unable to properly generate anything in some cases.
SuperchupuDev Reporter
Summary
An unsafe sanitization of dataset contents on the
MarkovData#getNextmethod used inMarkov#generateandMarkov#chooseallows a maliciously crafted string on the dataset to throw and stop the function from running properly.Details
kurwov/src/MarkovData.ts
Lines 38 to 44 in 0d58dfa
If a string contains a forbidden substring (i.e.
__proto__) followed by a space character, the second line will access a special property inMarkovData#finalDataby removing the last character of the string, bypassing the dataset sanitization (as it is supposed to be already sanitized before this function is called).datais then defined as the special function found in its prototype instead of an array.On the last line,
datais then indexed by a random number, which is supposed to return a string but returns undefined as it's a function. CallingendsWiththen throws.PoC
https://runkit.com/embed/m6uu40r5ja9b
Impact
Any dataset can be contaminated with the substring making it unable to properly generate anything in some cases.