Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--check-convergence & --force-convergence #98

Open
QianXiaobo opened this issue Mar 22, 2024 · 2 comments
Open

--check-convergence & --force-convergence #98

QianXiaobo opened this issue Mar 22, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@QianXiaobo
Copy link

Hi Xin,

Thanks for your nice work. I am confused about following two parameters in InferDM model. I think they both mean stop optimization runs when convergence.

--check-convergence CHECK_CONVERGENCE
                        Start checking for convergence after a chosen number of optimizations. Stop optimization runs when convergence criteria are reached. BestFit results file
                        will be call <output_prefix>.InferDM.bestfits. Convergence not checked by default.
--force-convergence FORCE_CONVERGENCE
                        Start checking for convergence after a chosen number of optimizations. Only stop optimization once convergence criteria is reached. BestFit results file
                        will be call <output_prefix>.InferDM.bestfits. Convergence not checked by default.

I also read the user guide but still don't know the difference between them. Could you please give me more details or example?
image

Bests,
Xiaobo

@xin-huang
Copy link
Owner

Hello @QianXiaobo

Thanks for testing dadi-cli.

I believe the --check-convergence option will stop the program after the number of iterations specified by the --optimization argument, regardless of convergence. If it achieves converged results before reaching the specified number of iterations, it may stop early. However, the --force-convergence option will ensure the program continues running until it achieves the converged results.

Maybe @tjstruck could provide more details?

@xin-huang xin-huang added the documentation Improvements or additions to documentation label Mar 22, 2024
@tjstruck
Copy link
Collaborator

Hi @QianXiaobo, @xin-huang is correct.

--force-convergence will run dadi-cli until convergence is met.
--check-convergence will run dadi-cli until the number of optimizations requested through --optimization is completed and stop early if convergence is met.

I'll update the documentation to help make the distinction clearer.

@tjstruck tjstruck self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants