-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot empty or delete VORBIS_COMMENT vendor string #640
Comments
Why do you want to remove it? |
I want to remove it, because i do not want that, when I give files to other people, that they can see which tool I used to create the FLAC. So for example if I rip a bluray with MakeMKV, I want to remove, that in the vendor string they can see MakeMKV. Can you please implement the feature to delete or empty the vendor string? |
This feature is really important for me and I think that this is not a big change and so not much work to implement. |
If you contribute a PR, it could be implemented next week. If not, I won't make any promises. As you can see from the issues list, there are open issues already 5 years old. |
From your question I take it that you know how to remove the VORBIS_COMMENT block entire, so here is a work-around. It will leave a vendor string, but not the right one: Dump the file(s) into Mp3tag Mp3tag will write back the tags, but not the correct vendor string - it will it will fill in a vendor string of some reference libflac version. |
I am not very good at C programming... so I think I can only wait until this feature will be implemented |
That is not what I want... I want a empty string or delete the vendor string completely |
Sure I read that. But it will serve this purpose:
If anonymity is what you seek, then replacing it by something common is more efficient than the empty string. |
I cannot find in the code where it will write "vendor string: reference libFLAC 1.4.3 20230623". |
Sure. It is right here Lines 47 to 59 in 31ccd3d
|
Ok and where in the metaflac code gets this called? |
That depends on what action metaflac does, specifically. Taking adding a vorbis comment block when there is none as an example, that would be. Here:
Then here: flac/src/libFLAC/metadata_object.c Line 468 in 31ccd3d
|
I changed, as workaround for myself, the variable FLAC__VENDOR_STRING in the code to an empty string and rebuild the metaflac.exe. |
How can I empty or delete VORBIS_COMMENT vendor string while keeping the comments?
The text was updated successfully, but these errors were encountered: