Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple's Accelerate framework support #25

Open
romanbsd opened this issue Apr 11, 2019 · 7 comments
Open

Apple's Accelerate framework support #25

romanbsd opened this issue Apr 11, 2019 · 7 comments

Comments

@romanbsd
Copy link
Contributor

I ported all of the CPU intensive parts of the echo cancellation and preprocess to use the Apple's Accelerate framework. If it's of any interest, I can prepare and submit a PR.

@yycking
Copy link

yycking commented Aug 4, 2023

@romanbsd
Can you share these code with me?

@romanbsd
Copy link
Contributor Author

Sorry, missed this comment. I think most (if not all) of it is here:
https://github.com/romanbsd/libspeexdsp
If something is missing, ping me in a week from now, since I'm abroad, and the files are on another computer.

@tmatth
Copy link
Member

tmatth commented Aug 24, 2023

@romanbsd do you have any benchmarks?

@romanbsd
Copy link
Contributor Author

No, don't have it handy, was too long ago. But it was at least 4x faster as far as I remember. Also I recall that there were places where I tried rewriting in order to use accelerated functions, and it wasn't worth it, so if you see places that are possible candidates - chances are that I already tried

@tmatth
Copy link
Member

tmatth commented Aug 24, 2023

No, don't have it handy, was too long ago. But it was at least 4x faster as far as I remember. Also I recall that there were places where I tried rewriting in order to use accelerated functions, and it wasn't worth it, so if you see places that are possible candidates - chances are that I already tried

Thanks I'll try and take a look, sorry this got missed (this github project is just a mirror of https://gitlab.xiph.org/xiph/speexdsp so PRs sent here can get overlooked).

@romanbsd
Copy link
Contributor Author

romanbsd commented Aug 25, 2023

Note that this is production quality code. It runs in production on iOS app for some years now. I also ported parts of Accelerate framework to Android (repo vdsp in my account)

@romanbsd
Copy link
Contributor Author

P.S. The changes are in the mdf.c and filterbank.c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants