-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inconsistency between the description of the onboarding task and the CI scripts #28
Comments
Thanks @Alex-Lian ! I personally don't like workarounds of the CI scripts, because it will end up with repeated efforts and redundant results. So I don't particularly like #2. But if you think it's fine, it's ok for me. Ideally we should ask students to work on separate tests. So I think what we should do is to find a way to achieve that via the onboarding tasks. I like #1 on changing the onboarding task. But it does not prevent students to concurrently choose two untouched tests (there is no lock to prevent data races). |
@Alex-Lian Also, is IDoCT specific to Hadoop? I think we should expand our repo sets, especially given that there are lots of efforts in https://github.com/xlab-uiuc/openctest to integrate with more repos. |
Yes, it is possible. One approach we can take is to modify the CI script approval process for each pull request, ordering them based on their open time. By implementing this change, the student who opens the pull request earlier will have the priority to choose the tests.
Yes, the current description of the onboarding task and the CI scripts is only for hadoop-common.
I can do it when I am available (after the paper ddl) or we can ask undergraduate students or student enrolled in 591 SE or students takeCS527 and want bonus point. |
yes but it's not ideal as it will inevitably run into the situation that someone worked hard with results but invalidated by the others. |
Indeed, to avoid such situation. We can suggust students to take the following steps before investing effort into the chosen Ctests. First, they can open a pull request to assert ownership of the selected tests by including this information in the description of the PR. Then, they can proceed to update the pull request with their results. |
As mentioned in the Pull Request #27, there is an inconsistency between the description of the onboarding task and the CI scripts
Currently, the onboarding task instructs students to randomly select five tests, while the CI scripts generate an error if the chosen tests have already been selected by other students.
To address this issue, we can implement the following solutions:
The text was updated successfully, but these errors were encountered: