Replies: 4 comments 9 replies
-
|
label 这种是事后的，只有提了 pr 才会被标记，但是都提了 pr 了，有没有这个都无所谓了。。 如果只是想提一两行，随时可以提。 |
Beta Was this translation helpful? Give feedback.
-
|
大意是作为维护者可以留下一些简单的修改，让新人快速熟悉Codebase 例如 https://github.com/llvm/llvm-project/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 比如某个地方留下了一个小功能没有完全实现，但要实现其实非常简单，可以留着给社区实现？或许是一个不错的尝试。 |
Beta Was this translation helpful? Give feedback.
-
可能误会我的意思了，是指issue的label而不是PR的label。可以写一些仓库目前存在的问题（简单的）然后依靠社区的力量开发 |
Beta Was this translation helpful? Give feedback.
-
|
这种老早有了， |
Beta Was this translation helpful? Give feedback.
-
https://github.com/xmake-io/xmake/blob/master/CONTRIBUTING.md 或许可以把链接加入到这个文档里？甚至README里？这样至少知道有这些label( |
Beta Was this translation helpful? Give feedback.
-
没用，CONTRIBUTING.md 和 readme 里面加了，也压根没人看。。 想贡献的，不提醒也会贡献，不想贡献的，到处加 link 也不会搭理。。 通常小改动 pr，都是为了解决用户自己遇到的问题，如果确实是小问题，我通常都会在 issues 里面直接回复，让他来个 pr 过来，告诉它修哪里。。也有不少人很乐意提 pr 过来，没必要这种 label. 如果不是自己遇到的 issues ，很少有人会主动来 pr 的 |
Beta Was this translation helpful? Give feedback.
-
|
Example: llvm/llvm-project#56159 |
Beta Was this translation helpful? Give feedback.
-
良好的社区还是应该有这种需求？总不可能一直让领导人一个人维护吧（？ |
Beta Was this translation helpful? Give feedback.
-
|
而且感觉已有的 |
Beta Was this translation helpful? Give feedback.
-
真的如果是很简单的改动，我都懒得一直放着 issues 等人不知道什么时候过来提 pr，我分分钟就直接改了完事了。。 |
Beta Was this translation helpful? Give feedback.
-
某种意义上留给社区改可以促进社区的发展（ |
Beta Was this translation helpful? Give feedback.
-
吸纳新的开发者的一个很好的来源 |
Beta Was this translation helpful? Give feedback.
-
|
放着不改，看着难受哈。。我还是直接改了吧。 |
Beta Was this translation helpful? Give feedback.
-
Is your feature request related to a problem? Please describe.
The development of an open source community requires the participation of a large number of developers, and a project itself has accumulated a large amount of source code. It is not such trivival to get started and complete a large functional modification (and submit patch / GH PR). This RFC recommends adding
good first issueto the github issues list to help those contributing to thexmakerepository for the first time with some reasonably small changes. Similar to only need to change one or two lines in the source code, but does not affect the function can be regarded asgood first issue一个开源社区的发展需要大量开发者参与，而一个项目本身积累了大量的源代码，入门并完成一个较大的功能修改并不是一件简单的事情。这个RFC建议在github issues列表中加入
good first issue来帮助那些第一次贡献给xmake仓库的人一些合理的小改动。类似于只需要在源代码中改一两行，但不影响功能的可以作为"good first issue"Describe the solution you'd like
Add
good first issuelabel in https://github.com/xmake-io/xmake/labels shall be fine.Describe alternatives you've considered
No response
Additional context
CC @waruqi
Beta Was this translation helpful? Give feedback.
All reactions