You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During a code review (#119 (comment)), @kristinaspring suggested using a waitgroup for our listeners. I think adding this will be helpful as a way to prevent unexpected behavior in listeners doing long running final updates after Stop() has finished.
I'm seeing this as a good opportunity to make the listeners restartable as well. That is, we should be able to make the sequence of operations Start(), Stop(), Start() without any issues or resource leaks.
During a code review (#119 (comment)), @kristinaspring suggested using a waitgroup for our listeners. I think adding this will be helpful as a way to prevent unexpected behavior in listeners doing long running final updates after Stop() has finished.
argus/chrysom/client.go
Line 279 in dd35ffe
The text was updated successfully, but these errors were encountered: