Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitgroup for listeners #126

Closed
joe94 opened this issue Feb 9, 2021 · 1 comment · Fixed by #128
Closed

Add waitgroup for listeners #126

joe94 opened this issue Feb 9, 2021 · 1 comment · Fixed by #128
Milestone

Comments

@joe94
Copy link
Member

joe94 commented Feb 9, 2021

During a code review (#119 (comment)), @kristinaspring suggested using a waitgroup for our listeners. I think adding this will be helpful as a way to prevent unexpected behavior in listeners doing long running final updates after Stop() has finished.

c.ticker.Stop()

@joe94 joe94 added this to the v0.3.11 milestone Feb 9, 2021
@joe94
Copy link
Member Author

joe94 commented Feb 10, 2021

I'm seeing this as a good opportunity to make the listeners restartable as well. That is, we should be able to make the sequence of operations Start(), Stop(), Start() without any issues or resource leaks.

@joe94 joe94 linked a pull request Feb 10, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant