Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caduceus cutoffs #185

Closed
gargidb opened this issue Mar 19, 2020 · 1 comment
Closed

Caduceus cutoffs #185

gargidb opened this issue Mar 19, 2020 · 1 comment
Labels
bug

Comments

@gargidb
Copy link
Contributor

gargidb commented Mar 19, 2020

Currently caduceus is able to send a cutoff message when already inside a cutoff window, as a result, we get multiple cutoffs. We want to prevent caduceus from sending another cutoff by checking if we are already inside a cutoff window.

Add check before dropUntil

https://github.com/xmidt-org/caduceus/blob/d445e08bdecabe906bfcc1bb9506a860874cef92/outboundSender.go#L606
@gargidb gargidb changed the title Caduceus cutoff period Caduceus cutoffs Mar 19, 2020
@joe94
Copy link
Member

joe94 commented Mar 24, 2020

fixed by #186

@joe94 joe94 closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joe94 @kristinapathak @gargidb