New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idiomatic full queue check #189

Closed

kristinapathak opened this issue Mar 26, 2020 · 0 comments · Fixed by #190

Assignees

Labels

Contributor

kristinapathak commented Mar 26, 2020

The check here can be written differently, where if we can't immediately push the event onto the channel, we know the queue is full:
https://github.com/xmidt-org/caduceus/blob/master/outboundSender.go#L418

Here is an example of how this can be written in a more idiomatic way:
https://gobyexample.com/non-blocking-channel-operations

This was originally brought up by @joe94 .

kristinapathak added the enhancement label

gargidb self-assigned this

gargidb linked a pull request

that will close this issue

Caduceus queue #190

Merged

gargidb closed this as completed in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment