You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@astro Looks like major changes in v8 are causing problems with node-expat under node 12. Did a quick stab fixing the obvious things but this seems to be relatively complicated and possibly interrelated with NaN
For reference see nodejs/node#23122 and bcoin-org/bcrypto#7
./node-expat.cc: At global scope:
../node-expat.cc:11:26: error: ‘Handle’ has not been declared
static void Initialize(Handle<Object> target)
^~~~~~
../node-expat.cc:11:32: error: expected ‘,’ or ‘...’ before ‘<’ token
static void Initialize(Handle<Object> target)
^
../node-expat.cc:481:23: error: ‘Handle’ has not been declared
void Emit(int argc, Handle<Value> argv[])
^~~~~~
../node-expat.cc:481:29: error: expected ‘,’ or ‘...’ before ‘<’ token
void Emit(int argc, Handle<Value> argv[])
^
../node-expat.cc: In static member function ‘static void Parser::Initialize(int)’:
../node-expat.cc:29:5: error: ‘target’ was not declared in this scope
target->Set(Nan::New("Parser").ToLocalChecked(), t->GetFunction());
^~~~~~
../node-expat.cc:29:5: note: suggested alternative: ‘Parse’
target->Set(Nan::New("Parser").ToLocalChecked(), t->GetFunction());
^~~~~~
Parse
../node-expat.cc:29:69: error: no matching function for call to ‘v8::FunctionTemplate::GetFunction()’
target->Set(Nan::New("Parser").ToLocalChecked(), t->GetFunction());
....
(for reference I have no problems doing the same install under node 11)
The text was updated successfully, but these errors were encountered:
@astro Looks like major changes in v8 are causing problems with node-expat under node 12. Did a quick stab fixing the obvious things but this seems to be relatively complicated and possibly interrelated with NaN
For reference see nodejs/node#23122 and bcoin-org/bcrypto#7
(for reference I have no problems doing the same install under node 11)
The text was updated successfully, but these errors were encountered: