-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with nan.h on windows (build fails) #78
Comments
Thanks! This only got merged in this morning so good reactions. Am testing out your fix here https://github.com/node-xmpp/node-expat/tree/dadleyy-nan-fix Once travis comes back with a go/no go I'll merge as appropriate. |
Ok, this change causes breakages on my current OS (OSX which was working before) and still fails on travis. Therefore we need to find another solution to this. I'll add a note to the README.md for you though. |
I got |
I had fatal error C1083: |
I was having an issue where during the node-gyp rebuild process on my windows machine:
After running
npm install nan --save
I was still getting the issue, so I went intonode-expat.cc
and changed the include to be a relative path:Now everything is working fine.
It seems like this is more of an issue with
node-gyp
not updating theinclude_dirs
in the build process on windows machines properly. Just wanted to make anyone who runs into this aware.The text was updated successfully, but these errors were encountered: