Signature not always the same #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmalzieu
commented
Sep 11, 2024
| let signature1_2 = try await privateKey.sign(stringToSign1.data(using: .utf8)!) | ||
| let uint1_2 = try [UInt8](signature1_2.serializedData()) | ||
|
|
||
| XCTAssertEqual(uint1_1, uint1_2) |
| let signature2_2 = try await privateKey.sign(stringToSign2.data(using: .utf8)!) | ||
| let uint2_2 = try [UInt8](signature2_2.serializedData()) | ||
|
|
||
| XCTAssertEqual(uint2_1, uint2_2) |
There was a problem hiding this comment.
Seems strange. Will add it to the backlog for investigation.
nmalzieu
commented
Sep 11, 2024
|
|
||
| XCTAssertEqual(uint1_1, uint1_2) | ||
|
|
||
| let stringToSign2 = "short" |
There was a problem hiding this comment.
at first I thought it was because the string was short but I managed to make it fail with longer strings also… maybe a byte length thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the string that we sign, signing twice yields the same result (expected), or not (bug)