Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDENTITY clause in column definition not handled #184

Closed
ctimmer opened this issue Jan 10, 2023 · 3 comments
Closed

IDENTITY clause in column definition not handled #184

ctimmer opened this issue Jan 10, 2023 · 3 comments
Assignees
@xnuinside

Comments

@ctimmer
Copy link

ctimmer commented Jan 10, 2023

Describe the bug
SQLServer - INDENTITY clause in column definition causes a problem with the entry size

To Reproduce
Steps to reproduce the behavior:
In the ddl:
[cifno] [numeric](10, 0) IDENTITY(1,1) NOT NULL,
puts (1,1) in the size field

Expected behavior
Either ignore the IDENTITY clause or create a separate object entry for the identity value

Screenshots
None

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser chrome
  • Version 01/10/2023
@xnuinside
Copy link
Owner

@ctimmer hi! thanks for reporting the issue, I will fix it in next release

@xnuinside xnuinside self-assigned this Jan 11, 2023
@xnuinside xnuinside mentioned this issue Mar 29, 2023
Merged
@xnuinside
Copy link
Owner

fix prepared in #195, I will comment one more time after version 0.30.0 will be released

@xnuinside
Copy link
Owner

@ctimmer just released version 0.30.0. Try it, test was added - https://github.com/xnuinside/simple-ddl-parser/blob/main/tests/dialects/test_mysql.py#L315. If will be needed something new - feel free to open the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xnuinside xnuinside

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctimmer @xnuinside