Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE SCHEMA IF NOT EXISTS STATEMENT with COMMENT #281

Closed
dmaresma opened this issue Aug 13, 2024 · 2 comments
Closed

CREATE SCHEMA IF NOT EXISTS STATEMENT with COMMENT #281

dmaresma opened this issue Aug 13, 2024 · 2 comments

Comments

@dmaresma
Copy link
Contributor

dmaresma commented Aug 13, 2024

Describe the bug
the following SQL statement fail :
CREATE SCHEMA IF NOT EXISTS TESTBLABLA COMMENT='my blabla comment';

from simple_ddl_parser import DDLParser local_ddl = """CREATE SCHEMA IF NOT EXISTS TESTBLABLA COMMENT='my blabla comment';""" schema_if_not_exists = DDLParser(local_ddl).run(output_mode="snowflake") expected = [{'if_not_exists': True, 'schema_name': 'TESTBLABLA', 'comment': "'my blabla comment'"}] #schema_if_not_exists assert(schema_if_not_exists == expected)

The schema / schema_name is not detected.

@dmaresma dmaresma changed the title CREATE SCHEMA IF NOT EXISTS STATEMENT CREATE SCHEMA IF NOT EXISTS STATEMENT with COMMENT Aug 14, 2024
@dmaresma
Copy link
Contributor Author

if I remove lines | create_schema id id id | create_schema id id STRING from p_create_schema in sql.py everything is back to normal, all test in success (supposed to mean no regressions)

@xnuinside
Copy link
Owner

@dmaresma we can remove it if all tests are green, maybe some artefact from the past. I always adding tests for statements, so if tests are green - feel free to delete it, or I can do it on weekends

@dmaresma dmaresma mentioned this issue Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants