Update IRremoteESP8266 to 2.7.4 #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix version specifier, use PIO registry instead of git Need this for -DALLOW_DELAY_CALLS=false
|
Not tested. Switch to the correct upstream version. Build did not break so hopefully things are fine at runtime too. IR module has a very strange flow :/ It feels like it was written this way for pubsub API which works only in CONT context and expects us to block the whole time while code is sending (based on comment about MQTT_MAX_PACKET_SIZE:). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix version specifier, use PIO registry instead of git
Need this for -DALLOW_DELAY_CALLS=false