From 832475fd91b5dc0c40a8477f47a21a422bd4cf14 Mon Sep 17 00:00:00 2001 From: Riccardo Magliocchetti Date: Wed, 31 Jul 2024 14:57:10 +0200 Subject: [PATCH] Use get_distribution consistently --- .../src/opentelemetry/instrumentation/fastapi/__init__.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py b/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py index 5d61918277..7f1913bcac 100644 --- a/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py +++ b/instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py @@ -172,7 +172,6 @@ def client_response_hook(span: Span, scope: dict[str, Any], message: dict[str, A --- """ import logging -from importlib.util import find_spec from typing import Collection import fastapi @@ -294,8 +293,12 @@ def instrumentation_dependencies(self) -> Collection[str]: except Exception: # pylint: disable=broad-exception-caught pass - if find_spec("fastapi") is not None: + try: + get_distribution("fastapi") return (_fastapi,) + except Exception: # pylint: disable=broad-exception-caught + pass + # If neither is installed, return both as potential dependencies return _instruments