This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
feat: DatePicker #49
Merged
feat: DatePicker #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
=========================================
Coverage ? 87.21%
=========================================
Files ? 15
Lines ? 446
Branches ? 109
=========================================
Hits ? 389
Misses ? 56
Partials ? 1
Continue to review full report at Codecov.
|
|
Deploy preview for wizard-ui ready! Built with commit ed93306 |
…icker * 'master' of github.com:xsky-fe/wizard-ui: feat: Add Dropdown component. (#47) # Conflicts: # src/interface.tsx
lijianxin1202
suggested changes
Aug 15, 2019
src/components/DatePicker/index.tsx
Outdated
| import { DatePickerProps } from '../../interface'; | ||
| import './style.scss'; | ||
|
|
||
| const format: string = 'YYYY-MM-DD HH:mm:ss'; |
There was a problem hiding this comment.
如果右边的 value 可以直接推断出类型，左侧可以不用指定
src/components/DatePicker/index.tsx
Outdated
|
|
||
| const format: string = 'YYYY-MM-DD HH:mm:ss'; | ||
|
|
||
| function getFormat(time: boolean | undefined) { |
There was a problem hiding this comment.
参数可以使用 time?: boolean 代替
src/components/DatePicker/index.tsx
Outdated
| getTime: PropTypes.func, | ||
| }; | ||
|
|
||
| DatePicker.defaultProps = { |
There was a problem hiding this comment.
可以把 defaultProps 类型单独定义出来，在这里显式指定，避免属性拼写或其他错误
lijianxin1202
suggested changes
Aug 15, 2019
src/components/DatePicker/index.tsx
Outdated
| }; | ||
|
|
||
| DatePicker.defaultProps = { | ||
| disabled: false, | ||
| showTime: true, | ||
| }; | ||
| } as DatePickerDefaultProps; |
There was a problem hiding this comment.
as 就做不到检查了，可以先定义 defaultProps 再赋值
const defaultProps: DatePickerDefaultProps = {
...
}
DatePicker.defaultProps = defaultProps;
lijianxin1202
approved these changes
Aug 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.