Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using h specifier might cause overlap with hour's specifier #8

Closed
xsoh opened this issue Jun 19, 2015 · 0 comments
Closed

Using h specifier might cause overlap with hour's specifier #8

xsoh opened this issue Jun 19, 2015 · 0 comments

Comments

@xsoh
Copy link
Owner

xsoh commented Jun 19, 2015

As @mj1856 suggested on this Add moment-hijri to plugins #164 pull, that the h specifier might cause overlap with hour's specifier.
For that it should be change to another specifier. The better specifier is to use i instead. That is because it represent Islamic Calendar and also Hijri has two I`s 👀

This change will make a big difference for the tool usage, for that I suggest to be the v2.0 of moment-hijri.

@xsoh xsoh closed this as completed in b82ed6d Jul 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant