Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable strictNullChecks #1319

Closed
Tyriar opened this issue Mar 9, 2018 · 1 comment
Closed

Enable strictNullChecks #1319

Tyriar opened this issue Mar 9, 2018 · 1 comment
Labels
type/debt Technical debt that could slow us down in the long run

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 9, 2018

A lot of errors when the flag is enabled in tsconfig, we should slowly chip away at them so we can turn the setting on 🙂
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Mar 9, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 9, 2018
@Tyriar
Fix strictNullChecks errors in AccessibilityManager
0eaebcd 
Part of xtermjs#1319
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 9, 2018
@Tyriar
Fix strictNullChecks errors in AccessibilityManager
4f0cc01 
Part of xtermjs#1319
@Tyriar Tyriar mentioned this issue Mar 9, 2018
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Mar 12, 2018
@Tyriar
Use bang operator for array methods
a59af66 
Part of xtermjs#1319
@Tyriar Tyriar mentioned this issue Mar 12, 2018
Merged
@Tyriar Tyriar mentioned this issue Jul 6, 2018
Closed
@Tyriar Tyriar mentioned this issue Aug 23, 2018
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 4, 2018
@Tyriar
Fix strict null checks in ./common
7c1b1e2 
Part of xtermjs#1319
@Tyriar Tyriar mentioned this issue Sep 4, 2018
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 17, 2018
@Tyriar
Enable strict null checks in common
8ec0a08 
Part of xtermjs#1507
Part of xtermjs#1319
@Tyriar Tyriar mentioned this issue Sep 17, 2018
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 17, 2018
@Tyriar
Enable strict null checks and restrict DOM access in common
a7a58aa 
Part of xtermjs#1507
Part of xtermjs#1319
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 18, 2018
@Tyriar
Enforce core layering and enable strict
fb0b73a 
Part of xtermjs#1507
Part of xtermjs#1319
@Tyriar Tyriar mentioned this issue Apr 28, 2019
Merged
@Tyriar Tyriar mentioned this issue May 10, 2019
Merged
@Tyriar Tyriar mentioned this issue May 18, 2019
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jun 1, 2019

Closing this off in favor of #1507

@Tyriar Tyriar closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyriar