Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use project references coming in TypeScript v3 #1337

Closed
Tyriar opened this issue Mar 16, 2018 · 2 comments · Fixed by #1984
Closed

Use project references coming in TypeScript v3 #1337

Tyriar opened this issue Mar 16, 2018 · 2 comments · Fixed by #1984
Assignees
@Tyriar
Labels
type/debt Technical debt that could slow us down in the long run
Milestone
3.13.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 16, 2018 •
edited
Loading

This is an issue for the future when TS 3 is released. With it are coming composite projects (ie. project references). This will allow us to section out our various layers and put hard references between them, so we could have a shared project instead of just a folder (and enforce compile/lint rules for that environment). Eventually maybe we would have a web worker and browser project as well.
@Tyriar Tyriar added the type/debt Technical debt that could slow us down in the long run label Mar 16, 2018
@Tyriar Tyriar mentioned this issue May 4, 2018
Merged
@Tyriar Tyriar mentioned this issue Jun 10, 2018
Closed
@Tyriar Tyriar changed the title Use composite projects coming in TypeScript v3 Use project references coming in TypeScript v3 Sep 4, 2018
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 4, 2018
@Tyriar
Have common only reference within common
443b2db 
Part of xtermjs#1337
@Tyriar Tyriar mentioned this issue Sep 4, 2018
Merged
@Tyriar Tyriar self-assigned this Sep 21, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Sep 21, 2018

I have a WIP at https://github.com/Tyriar/xterm.js/tree/1337_project_refs_part_2, we need to wait until 3.1 before we adopt this.

@Tyriar
Copy link
Member Author

Tyriar commented Feb 1, 2019

Apparently watch is much better in TS 3.3

@Tyriar Tyriar added this to the 3.13.0 milestone Mar 30, 2019
@Tyriar Tyriar mentioned this issue Mar 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/debt Technical debt that could slow us down in the long run
Projects
None yet
Milestone
3.13.0
Development

Successfully merging a pull request may close this issue.

Build using TypeScript project references Tyriar/xterm.js
1 participant
@Tyriar