Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectionRenderLayer renders on top of TextRenderLayer #1539

Closed
vincentwoo opened this issue Jun 29, 2018 · 1 comment
Closed

SelectionRenderLayer renders on top of TextRenderLayer #1539

vincentwoo opened this issue Jun 29, 2018 · 1 comment

Comments

@vincentwoo
Copy link
Contributor

Excuse me if I am mistaken, but it appears xterm intentional draws the selection layer over the text layer. If you specify a selection theme color that is opaque, it will fully obscure the text beneath it. Non-opaque selections mix their color with the text layers beneath.

I'm not exactly sure what the reference xterm application does, but if you highlight in ITerm2, the selection layer is opaque and drawn behind the text layer. The color of the text layer is overridden to be a standard color for selections, which works well.

I think this is a better approach than trying to mix the colors of the selection and text layers.

@Tyriar
Copy link
Member

Tyriar commented Jun 29, 2018

Duplicate #720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants