Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid shift call in Terminal._innerWrite #1955

Closed
Tyriar opened this issue Mar 4, 2019 · 0 comments
Closed

Avoid shift call in Terminal._innerWrite #1955

Tyriar opened this issue Mar 4, 2019 · 0 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 4, 2019

This call is expensive:

const data = this.writeBuffer.shift();

We should not be manipulating the incoming buffer strings, instead passing the original string in with an offset would be better.. Some more context: #1818

Related: #1818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant