Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchAddon shows wrong selection when bounding with wide unicode chars #3235

Closed
gera2ld opened this issue Jan 29, 2021 · 1 comment
Closed

SearchAddon shows wrong selection when bounding with wide unicode chars #3235

gera2ld opened this issue Jan 29, 2021 · 1 comment
Labels
duplicate

Comments

@gera2ld
Copy link
Contributor

gera2ld commented Jan 29, 2021

When the matched content starts right after a wide unicode char, the selection appears to start from the middle of the unicode char before it.

Screen Shot 2021-01-29 at 11 51 20

When the matched content ends with a wide unicode char, the selection appears to include only half of the char.

Screen Shot 2021-01-29 at 12 01 30

This can be reproduced in browsers and VSCode.

Details

  • Browser and browser version: Firefox 85 / Chrome 88 / VSCode 1.52.1
  • OS version: macOS 10.15.7
  • xterm.js version: 4.9.0

Steps to reproduce

  1. Input 中文xxx in terminal
  2. Search xxx for the first case
  3. Search 中 for the second case
@gera2ld gera2ld mentioned this issue Jan 29, 2021
Merged
@Tyriar
Copy link
Member

Tyriar commented Jan 29, 2021

duplicate of #1686

@Tyriar Tyriar closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @gera2ld