Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow decorations to show up in the scroll bar #3632

Closed
Tyriar opened this issue Feb 10, 2022 · 3 comments · Fixed by #3676
Closed

Allow decorations to show up in the scroll bar #3632

Tyriar opened this issue Feb 10, 2022 · 3 comments · Fixed by #3676
Assignees
@meganrogge
Labels
type/enhancement Features or improvements to existing features
Milestone
4.19.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 10, 2022

Similar to monaco:

image
@Tyriar Tyriar added the type/enhancement Features or improvements to existing features label Feb 10, 2022
@Tyriar Tyriar mentioned this issue Feb 10, 2022
Closed
@meganrogge
Copy link
Member

meganrogge commented Feb 18, 2022 •
edited
Loading

Just like the editor, should show a decoration for the cursor when it's outside of the viewport (because you've scrolled)

@Tyriar
Copy link
Member Author

Tyriar commented Feb 18, 2022

Not sure showing the cursor is that useful as it's always in the viewport down the bottom and almost always on the very last line

@meganrogge
Copy link
Member

Yeah good point

@Tyriar Tyriar closed this as completed Mar 7, 2022
@Tyriar Tyriar reopened this Mar 7, 2022
@Tyriar Tyriar mentioned this issue Mar 7, 2022
Closed
@Tyriar Tyriar added this to the 4.19.0 milestone Mar 7, 2022
@meganrogge meganrogge mentioned this issue Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meganrogge meganrogge

Labels
type/enhancement Features or improvements to existing features
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

add overview ruler meganrogge/xterm.js
2 participants
@Tyriar @meganrogge