-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
. #4857
Comments
Oh we haven't published that addon yet, I'm guessing since you published your own we now need to change the name of the addon |
Removing the install step in #4858 |
@hktalent we never announced nor released unicode-graphemes, additionally there's also a big warning at the top of the readme that using it might cause issues. I really don't think this is a problem. |
I second that. CVEs are meant to inform about critical software bugs and vulnerabilities, not to inform ppl, that you rogue-sniped a package name we maybe would have used in the future (which is unfortunate for us, but no biggie). It is still the users responsibility to check the origin of a software package. @Tyriar I just talked about the issue with a friend - he suggested to check if we can open an org on npm and use a "@namespace" prefix on the npm packages (should be lockable on that org) to avoid these sort of issues in the future. |
@jerch 👍 created https://www.npmjs.com/org/xtermjs |
I just realized I had already created https://www.npmjs.com/org/xterm in the past |
Well tricky part prolly is to get that namespace thingy rolling? Idk how that works, would that turn |
@hktalent thanks for bringing this to our attention though, the project is definitely better/safer thanks to your report ❤️ |
FYI, an article popped up today in a daily newsletter I receive from https://tldr.tech/ linking to https://blog.phylum.io/dozens-of-npm-packages-caught-attempting-to-deploy-reverse-shell/ It appears that the individual here also registered https://www.npmjs.com/package/xterm-addon-clipboard?activeTab=code https://www.npmjs.com/package/xterm-addon-unicode-graphemes?activeTab=code Although there is not a CVE here, I would recommend possibly contacting NPM repos and requesting they take them down to avoid accidental installs. |
@davidfiala Thx for bringing this to our attention. Do you happen to have some insights about what the malware exactly does? It might also be a good idea to save log files, just in case this gets into a real law waters. @Tyriar We prolly should flag these packages as malware on npm via this form: https://www.npmjs.com/support?inquire=security&security-inquire=malware&package=xterm-addon-clipboard&version=6.0.4 Or if you have any way to contact npm peeps, whatever works here... Edit: @davidfiala Nevermind, the phylum article has a deeper walkthrough on it... |
Little annoying that the package names were getting sniped, including future ones coming in PRs #4220. But anyway, the problem is fixed now that we're using scoped. I reported the packages, though it would have been better to get a heads up rather than actually publishing a reverse shell. |
@hktalent If you are looking for collecting bounties here - sorry you are barking up the wrong tree. This project is fully voluntary OSS-driven, we have lit. 0 bucks at disposal. |
No description provided.
The text was updated successfully, but these errors were encountered: